[Webkit-unassigned] [Bug 199951] New: Need to skip test cache directory data vault for non internal build

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=199951

            Bug ID: 199951
           Summary: Need to skip test cache directory data vault for non
                    internal build
           Product: WebKit
           Version: Safari Technology Preview
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: zhifei_fang at apple.com

JSScript.mm:97

#if USE(APPLE_INTERNAL_SDK)
    if (rootless_check_datavault_flag(FileSystem::fileSystemRepresentation(directory).data(), nullptr)) {
        createError([NSString stringWithFormat:@"Cache directory `%@` is not a data vault", static_cast<NSString *>(directory)], error);
        return false;
    }
#endif



testapi.mm:2408

testInvalidCacheURL([NSURL URLWithString:@""], @"Cache path `` is not a local file");
testInvalidCacheURL([NSURL URLWithString:@"file:///"], @"Cache path `/` already exists and is not a file");
testInvalidCacheURL([NSURL URLWithString:@"file:///a/b/c/d/e"], @"Cache directory `/a/b/c/d` is not a directory or does not exist");
testInvalidCacheURL([NSURL URLWithString:@"file:///private/tmp/file.cache"], @"Cache directory `/private/tmp` is not a data vault");
^ this test run without checking if USE(APPLE_INTERNAL_SDK), we don't check this for non internal build (see JSScript.mm:97), therefore no error message will be created, this test will be failed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190719/f4fedf39/attachment.html>