[Webkit-unassigned] [Bug 191498] [Curl] implement CertificateInfo::summaryInfo

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191498

--- Comment #29 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 374451
  --> https://bugs.webkit.org/attachment.cgi?id=374451
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374451&action=review

> Source/WTF/wtf/persistence/PersistentCoders.h:153
> -        encoder.encodeFixedLengthData(reinterpret_cast<const uint8_t*>(vector.data()), vector.size() * sizeof(T), alignof(T));
> +        encoder.encodeFixedLengthData(reinterpret_cast<const uint8_t*>(vector.data()), vector.size() * sizeof(T));

Why does this no longer match ArgumentCoders.h? Why did you make this change?

> Source/WebCore/platform/network/curl/CertificateInfo.h:84
> +    static bool decode(Decoder& decoder, WebCore::CertificateInfo& certificateInfo)

Please use modern decoding that returns an Optional<WebCore::CertificateInfo>. Decoders that return a bool prevent us from removing default constructors in decodable classes.

> Source/WebCore/platform/network/curl/OpenSSLHelper.cpp:56
> +        if (*ptr)
> +            OPENSSL_free(*ptr);

How do we know there will only be one thing needing OPENSSL_free here?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190719/a3956305/attachment.html>