[Webkit-unassigned] [Bug 199710] Remove pywebsockets from thirdparty

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 18 10:17:06 PDT 2019


--- Comment #19 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 374383
  --> https://bugs.webkit.org/attachment.cgi?id=374383

View in context: https://bugs.webkit.org/attachment.cgi?id=374383&action=review

Python changes mostly looks good, I have one small question about six.

> Tools/Scripts/webkitpy/layout_tests/servers/websocket_server.py:123
> +        pywebsocket_deps = [self._filesystem.join(wpt_tools_base, "third_party", "six")]

We have our own version of six in Tools/Scripts/webkitpy/thirdparty/autoinstalled. I don't think that we have ambiguity problems because it's always imported through 'import autoinstalled.six',  but this still seems potentially dangerous...especially if the wpt version of six is different than the one we have have previously loaded. Do we actually need this? We probably do, it just feels super weird to have six both autoinstalled and checked into LayoutTests/imported/w3c.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190718/5e93b099/attachment-0001.html>

More information about the webkit-unassigned mailing list