[Webkit-unassigned] [Bug 199489] run-javascriptcore-tests won't report test results for testmasm, testair, testb3, testdfg and test api

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=199489

--- Comment #60 from Guillaume Emont <guijemont at igalia.com> ---
Comment on attachment 374307
  --> https://bugs.webkit.org/attachment.cgi?id=374307
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374307&action=review

> Tools/Scripts/webkitpy/common/config/ports.py:259
> +"""
> +    def run_javascriptcore_tests_command(self, build_style=None):
> +        command = self.script_shell_command("run-javascriptcore-tests")
> +        command.append("--no-fail-fast")
> +        command.append("--no-testmasm")
> +        command.append("--no-testair")
> +        command.append("--no-testb3")
> +        command.append("--no-testdfg")
> +        command.append("--no-testapi")
> +        if 'JSCTESTS_OPTIONS' in os.environ:
> +            command += os.environ['JSCTESTS_OPTIONS'].split()
> +        return self._append_build_style_flag(command, build_style)
> +"""

I'm confused as to why the jsc-mips and jsc-armv7 bubbles show green, but things definitely fail there with this version with this code between quotes. A previous version was working for them.
Other than removing the quotes, uou might want to add some conditions on the arch here, since I think that the jsc-i386 and jsc EWS should be able to run these binaries (unless they're already in the new EWS, in which case they wouldn't be affected, but I suspect that at least jsc-i386 is still on the old EWS).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190717/55a6bf6c/attachment.html>