[Webkit-unassigned] [Bug 199845] Hang in WebCore::AccessibilityRenderObject::visiblePositionRangeForLine.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=199845

--- Comment #5 from Andres Gonzalez <andresg_22 at apple.com> ---
(In reply to chris fleizach from comment #3)
> Comment on attachment 374270 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=374270&action=review
> 
> > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:-1970
> > -    if (!lineCount || !m_renderer)
> 
> NSNotFound is an apple thing, so this check needs to be in the Mac wrapper.
> also probably sufficient to check if it’s equals to nsnotfound. I think it’s
> already uint max so it won’t matter checking higher
>

Done.

> > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1983
> > +            || visiblePos.equals(savedVisiblePos))
> 
> surprised the == operator doesn’t call .equals directly

The equals method has a FIXME comment in the header file:
    // FIXME: Combine this function with operator==
and looking at the implementation, it does a lot more than operator==.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190717/f5861b11/attachment-0001.html>