[Webkit-unassigned] [Bug 199845] Hang in WebCore::AccessibilityRenderObject::visiblePositionRangeForLine.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 16 19:57:38 PDT 2019
https://bugs.webkit.org/show_bug.cgi?id=199845
--- Comment #3 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 374270
--> https://bugs.webkit.org/attachment.cgi?id=374270
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=374270&action=review
> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:-1970
> - if (!lineCount || !m_renderer)
NSNotFound is an apple thing, so this check needs to be in the Mac wrapper. also probably sufficient to check if itâs equals to nsnotfound. I think itâs already uint max so it wonât matter checking higher
> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1983
> + || visiblePos.equals(savedVisiblePos))
surprised the == operator doesnât call .equals directly
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190717/70c04570/attachment-0001.html>
More information about the webkit-unassigned
mailing list