[Webkit-unassigned] [Bug 199845] Hang in WebCore::AccessibilityRenderObject::visiblePositionRangeForLine.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 16 19:57:38 PDT 2019


--- Comment #3 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 374270
  --> https://bugs.webkit.org/attachment.cgi?id=374270

View in context: https://bugs.webkit.org/attachment.cgi?id=374270&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:-1970
> -    if (!lineCount || !m_renderer)

NSNotFound is an apple thing, so this check needs to be in the Mac wrapper. also probably sufficient to check if it’s equals to nsnotfound. I think it’s already uint max so it won’t matter checking higher

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1983
> +            || visiblePos.equals(savedVisiblePos))

surprised the == operator doesn’t call .equals directly

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190717/70c04570/attachment-0001.html>

More information about the webkit-unassigned mailing list