[Webkit-unassigned] [Bug 199621] [WPE][GTK] UI process crash due to NULL dereference in webkitWebViewResourceLoadStarted()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 16 08:04:32 PDT 2019


--- Comment #10 from Michael Catanzaro <mcatanzaro at igalia.com> ---
At the risk of complicating this further: sometimes Apple uses ASSERT() to catch the problem in debug builds, but still handles the problem in release builds anyway. E.g.

auto* something = message.get();
if (!something)

I think that's extremely confusing because it creates the incorrect impression that the condition below is redundant and can be removed, but it's a pattern that is occasionally used in WebKit. The advantage of that is that you still get the ASSERT in debug mode for developer convenience, but not in release builds where it would be a vulnerability.

I don't suggest using this pattern, but it's not necessarily a bug if you find it elsewhere.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190716/8dbb9831/attachment-0001.html>

More information about the webkit-unassigned mailing list