[Webkit-unassigned] [Bug 199650] Keyword lookup can use memcmp to get around unaligned load undefined behavior

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 15 11:27:28 PDT 2019


Yusuke Suzuki <ysuzuki at apple.com> changed:

           What    |Removed                     |Added
                 CC|                            |ysuzuki at apple.com
 Attachment #373806|review?                     |review+
              Flags|                            |

--- Comment #4 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 373806
  --> https://bugs.webkit.org/attachment.cgi?id=373806

View in context: https://bugs.webkit.org/attachment.cgi?id=373806&action=review

r=me with nit.

> Source/JavaScriptCore/KeywordLookupGenerator.py:170
> +                    needle = "(Char []){" + ", ".join(["'%s'" % (c) for c in test]) + "}"

Can you change it to "static_cast" instead of C-style cast?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190715/b5c78f35/attachment-0001.html>

More information about the webkit-unassigned mailing list