[Webkit-unassigned] [Bug 199748] New: [ATK] Avoid unneeded call to to core(selection) in listObjectForSelection()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=199748

            Bug ID: 199748
           Summary: [ATK] Avoid unneeded call to to core(selection) in
                    listObjectForSelection()
           Product: WebKit
           Version: Other
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Accessibility
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: aperez at igalia.com
                CC: webkit-bug-importer at group.apple.com

In Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceSelection.cpp:

The “coreSelection“ returned by “core()” is already null-checked inside
“optionFromList()” before calling “listObjectForSelection”, and this is
the only call site. While technically there is no issue here, a small
refactoring could be done to pass “coreSelection” to it, instead of
passing the plain “selection” and needing to call “core(selection)”
multiple times.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190712/4b5f9e35/attachment-0001.html>