[Webkit-unassigned] [Bug 191498] [Curl] implement CertificateInfo::summaryInfo

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191498

--- Comment #20 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 373889
  --> https://bugs.webkit.org/attachment.cgi?id=373889
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373889&action=review

> Source/WebCore/platform/network/curl/CertificateInfoCurl.cpp:76
> +    auto commonName = OpenSSL::createPtr<uint8_t>();

Looks so bad. The previous your code looks better: OpenSSL::Ptr commonName;
You can specify a lambda as deleter of std::unique_ptr. Google "lambda deleter std::unique_ptr".
You can improve more.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190711/73fdfc01/attachment.html>