[Webkit-unassigned] [Bug 199489] run-javascript-core-test won't report json results for testmasm, testair, testb3, testdfg and test api

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=199489

--- Comment #13 from Zhifei Fang <zhifei_fang at apple.com> ---
(In reply to Aakash Jain from comment #12)
> Comment on attachment 373850 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=373850&action=review
> 
> > Tools/Scripts/run-javascriptcore-tests:413
> > +        reportTestFailures();
> 
> Do you want to run this method only in case of failFast?
> 
> I see that this method is called at the end as well, but that would probably
> report test failures only for last function call.

I call it at the end because I will have some format like this:



** The following JSC stress test failures have been introduced:
        mozilla-tests.yaml/js1_5/Array/regress-101964.js.mozilla-ftl-eager-no-cjit-validate-phases
        mozilla-tests.yaml/js1_5/Array/regress-101964.js.mozilla-llint
        mozilla-tests.yaml/js1_5/Array/regress-101964.js.mozilla-no-ftl

Results for JSC stress tests:
    3 failures found.


** The following JSC test binaries failures have been introduced:
        testmasm
        testair
        testb3
        testdfg
        testapi

Results for JSC test binaries:
    5 failures found.



We will put all the report together. This will be good for bot watcher to look at.

Also, if we have fail fast option, that means it should quit whenever a failures found, we should also print this summary, it will look like this:


testApi completed with rc=5
** The following JSC test binaries failures have been introduced:
        testapi

Results for JSC test binaries:
    1 failure found.


> 
> > Tools/Scripts/run-javascriptcore-tests:421
> > +  if ($numJSCtestFailures) {
> 
> Do you want to exit early here if numJSCtestFailures is 0?


No, if there are no test failures, it should print out the summary as well:

like this:

Results for JSC test binaries:
    0 failure found.
OK

This is also the same logic for the jsc stress tests report.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190710/63582dc0/attachment.html>