[Webkit-unassigned] [Bug 196998] AX: HTML datalist accessibility is not exposed by WebKit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=196998

--- Comment #9 from Andres Gonzalez <andresg_22 at apple.com> ---
(In reply to chris fleizach from comment #3)
> Comment on attachment 373744 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=373744&action=review
> 
> > Source/WebCore/accessibility/AccessibilityObject.cpp:2795
> > +    RefPtr<Element> element = this->element();
> 
> auto
>
Thought that RefPtr does some referencing counting on the pointer it holds and thus it would be better to type it explicitly. Never know what these functions that return a naked pointer are doing behind the scene.

> > Source/WebCore/accessibility/AccessibilityObject.cpp:2799
> > +    RefPtr<Element> datalist = element->treeScope().getElementById(datalistId);
> 
> auto
> 
Changed this one to auto but feel that is an example of auto abuse since it is harder to figure out the type of datalist from the initialization on the right hand side than actually typing the variable explicitly.

> > Source/WebCore/accessibility/AccessibilityObject.cpp:2800
> > +    return (datalist && is<HTMLDataListElement>(datalist));
> 
> the datalist pointer check seems like it might not necessary since
> is<HTMLDataListElement> should handle the null

Done.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190709/cdfd6207/attachment.html>