[Webkit-unassigned] [Bug 191498] [Curl] implement CertificateInfo::summaryInfo

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 9 00:15:04 PDT 2019


--- Comment #7 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 373699
  --> https://bugs.webkit.org/attachment.cgi?id=373699

View in context: https://bugs.webkit.org/attachment.cgi?id=373699&action=review

> Source/WebCore/platform/network/curl/CertificateInfo.h:76
> +        auto certificateChain = certificateInfo.certificateChain();

This is a common C++ pit-hole. The type of certificateInfo.certificateChain() is "const Vector<Certificate>&", but type of auto drops & and "const Vector<Certificate>".
Then, this sentence copies the Vector.
auto& certificateChain = certificateInfo.certificateChain();

> Source/WebCore/platform/network/curl/CertificateInfo.h:80
> +        for (auto certificate : certificateChain) {

auto& certificate

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190709/200a8fac/attachment-0001.html>

More information about the webkit-unassigned mailing list