[Webkit-unassigned] [Bug 199489] run-javascript-core-test won't report json results for testmasm, testair, testb3, testdfg and test api

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=199489

--- Comment #6 from Zhifei Fang <zhifei_fang at apple.com> ---
(In reply to Aakash Jain from comment #5)
> Comment on attachment 373665 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=373665&action=review
> 
> > Tools/Scripts/run-javascriptcore-tests:404
> > +        writeJsonDataIfApplicable();
> 
> Since the runTest() method is called multiple times, wouldn't the json
> results be overwritten after every function call, and only 'testapi' results
> be reported?
> 
> may also modify 'writeJsonDataIfApplicable' to append (>>) instead of
> overwritting(>), and delete any old data from the file before starting the
> tests.

I found I have modified the wrong place, it should write the json file at then end. Will provide another patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190708/04301d76/attachment.html>