[Webkit-unassigned] [Bug 199535] New: WebBackForwardListItem::setPageState should receive pageState by reference

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=199535

            Bug ID: 199535
           Summary: WebBackForwardListItem::setPageState should receive
                    pageState by reference
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: Trivial
          Priority: P2
         Component: WebKit2
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at igalia.com
            Blocks: 104114

Coverity is complaining here about copying PageState by value in the parameter list. It's sort of a false positive, in that the PageState really does need to be copied here, so this is the best we can do. But pass by value and then WTFMove() is a pretty strange way to write it. Just passing by reference would be better. Then it will be copied into m_itemState.pageState.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190705/23944002/attachment.html>