[Webkit-unassigned] [Bug 199209] [Catalina] Enable WebKit build

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=199209

--- Comment #23 from Darin Adler <darin at apple.com> ---
Comment on attachment 373407
  --> https://bugs.webkit.org/attachment.cgi?id=373407
patch-7

View in context: https://bugs.webkit.org/attachment.cgi?id=373407&action=review

> Source/WebCore/PAL/pal/spi/mac/NSViewSPI.h:58
> +#if !HAVE(SUBVIEWS_IVAR_SPI)
> + at implementation NSView (SubviewsIvar)
> +
> +- (void)_setSubviewsIvar:(NSMutableArray<__kindof NSView *> *)subviews {
> +    ALLOW_DEPRECATED_DECLARATIONS_BEGIN
> +    _subviews = subviews;
> +    ALLOW_DEPRECATED_DECLARATIONS_END
> +}
> +
> +- (NSMutableArray<__kindof NSView *> *)_subviewsIvar {
> +    ALLOW_DEPRECATED_DECLARATIONS_BEGIN
> +    return (NSMutableArray *)_subviews;
> +    ALLOW_DEPRECATED_DECLARATIONS_END
> +}
> +
> + at end
> +#endif

This part must not be in a header. It needs to be in a .m or .mm file. Perhaps we can leave it in WebHTMLView.mm for now.

> Source/WebKitLegacy/mac/WebView/WebView.mm:5812
>      ALLOW_DEPRECATED_DECLARATIONS_BEGIN

Should remove this.

> Source/WebKitLegacy/mac/WebView/WebView.mm:5817
>      ALLOW_DEPRECATED_DECLARATIONS_END

And this.

> Source/WebKitLegacy/mac/WebView/WebView.mm:5821
>      ALLOW_DEPRECATED_DECLARATIONS_BEGIN

And this.

> Source/WebKitLegacy/mac/WebView/WebView.mm:5824
>      ALLOW_DEPRECATED_DECLARATIONS_END

And this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190703/1dbadbc0/attachment.html>