[Webkit-unassigned] [Bug 199416] [WPE][GTK] Remove flatpak sandbox

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=199416

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcatanzaro at igalia.com
 Attachment #373351|review?                     |review+
              Flags|                            |

--- Comment #4 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 373351
  --> https://bugs.webkit.org/attachment.cgi?id=373351
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373351&action=review

> Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:130
> -    if (sandboxEnabled && isInsideFlatpak())
> -        process = flatpakSpawn(launcher.get(), m_launchOptions, argv, socketPair.client, &error.outPtr());
> -#if ENABLE(BUBBLEWRAP_SANDBOX)
> -    else if (sandboxEnabled)
> +    if (sandboxEnabled)
>          process = bubblewrapSpawn(launcher.get(), m_launchOptions, argv, &error.outPtr());
> -#endif
>      else
>  #endif

Don't we still need the isInsideFlatpak() check? Surely bubblewrap isn't going to work inside flatpak?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190702/1f74cb36/attachment.html>