[Webkit-unassigned] [Bug 198604] Refactoring of architectural Register Information

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=198604

--- Comment #61 from Paulo Matos <pmatos at igalia.com> ---
Thank you for your time reviewing this.

(In reply to Keith Miller from comment #60)
> Comment on attachment 373008 [details]
> Post-5 Review Patch
> > Source/JavaScriptCore/assembler/X86_64Registers.h:92
> > +    macro(xmm10,"xmm10", 0, 0)                  \
> > +    macro(xmm11,"xmm11", 0, 0)                  \
> > +    macro(xmm12,"xmm12", 0, 0)                  \
> > +    macro(xmm13,"xmm13", 0, 0)                  \
> > +    macro(xmm14,"xmm14", 0, 0)                  \
> > +    macro(xmm15,"xmm15", 0, 0)
> 
> Can you add a space after these register identifiers? That would match
> webkit style.
> 

Thank you for your time reviewing this. Shall I align all the others columns as well then for ease of reading the table like so:
#define FOR_EACH_FP_REGISTER(macro)              \
    macro(xmm0,  "xmm0",  0, 0)                  \
    macro(xmm1,  "xmm1",  0, 0)                  \
    macro(xmm2,  "xmm2",  0, 0)                  \
    macro(xmm3,  "xmm3",  0, 0)                  \
    macro(xmm4,  "xmm4",  0, 0)                  \
    macro(xmm5,  "xmm5",  0, 0)                  \
    macro(xmm6,  "xmm6",  0, 0)                  \
    macro(xmm7,  "xmm7",  0, 0)                  \
    macro(xmm8,  "xmm8",  0, 0)                  \
    macro(xmm9,  "xmm9",  0, 0)                  \
    macro(xmm10, "xmm10", 0, 0)                  \
    macro(xmm11, "xmm11", 0, 0)                  \
    macro(xmm12, "xmm12", 0, 0)                  \
    macro(xmm13, "xmm13", 0, 0)                  \
    macro(xmm14, "xmm14", 0, 0)                  \
    macro(xmm15, "xmm15", 0, 0)

That would mean two spaces between 'xmm0,' and '"xmm0"' but I think it improves clarity. I have done this elsewhere.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190702/362f3aa9/attachment.html>