[Webkit-unassigned] [Bug 199300] [Curl] Fix CookieJarCurl::getRawCookie.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 1 18:27:27 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=199300

--- Comment #15 from Takashi Komori <Takashi.Komori at sony.com> ---
(In reply to Fujii Hironori from comment #9)
> Comment on attachment 373072 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=373072&action=review
> 
> >>> LayoutTests/http/tests/inspector/page/get-cookies.html:60
> >>> +            InspectorTest.awaitEvent("LoadComplete").then((event) => {
> >> 
> >> Should you call InspectorTest.awaitEvent() before InspectorTest.evaluateInPage()? It seems that other test do so.
> > 
> > In this part we evaluate 'loadDocumentWithURL()' in test page and wait the results of the evaluation, and then check results.
> > So if we call evaluateInPage() before awaitEvent(), this test doesn't work.
> 
> Do you mean "if we call awaitEvent() before evaluateInPage()"?
> Why? I think awaitEvent should be called before evaluateInPage because it
> needs to register a event listener before start loading.

I misunderstood. Fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190702/5bf384b4/attachment.html>


More information about the webkit-unassigned mailing list