[Webkit-unassigned] [Bug 191303] DumpRenderTree should report unknown options

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191303

--- Comment #17 from darshan <dkadu at igalia.com> ---
(In reply to Frédéric Wang (:fredw) from comment #16)
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=360733&action=review
> 
> So now some tests are crashing, which is good news: Your patch really has an
> effect. Let's add support for the condition you mentioned in comment 6 now.
> 
> > Tools/DumpRenderTree/TestOptions.cpp:115
> > +            RELEASE_ASSERT(false);
> 
> It does not seem nice to use a hardcoded boolean here. Can you please use
> RELEASE_ASSERT_NOT_REACHED instead?

Okay I will add

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190131/8a541ac2/attachment.html>