[Webkit-unassigned] [Bug 193213] Fix Resource Timing buffer edge cases for WPT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=193213

--- Comment #31 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 360345
  --> https://bugs.webkit.org/attachment.cgi?id=360345
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360345&action=review

> Source/WebCore/page/Performance.cpp:249
> +        if (beforeCount <= afterCount) {

If this check is true, it seems we would be loosing some information, how big an issue is it?
Should we do a smarter check here?
Something like, continue if we ever queue any entry. Or is there a risk with that approach?

> LayoutTests/imported/w3c/web-platform-tests/resource-timing/redirects.sub-expected.txt:7
> +FAIL Testing resource entries assert_unreached: http://localhost:8800/common/redirect.py?location=https://www.localhost:9443/resource-timing/resources/blank_page_green.htm?id=xhr is expected to be in the Resource Timing buffer Reached unreachable code

We probably could rewrite the test (as a WPT PR) to make www.localhost be 127.0.0.1 in that context.
Ditto below.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190128/14a596ab/attachment.html>