[Webkit-unassigned] [Bug 193878] AX: VoiceOver allows to interact with a disabled <select> element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=193878

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wenson_hsieh at apple.com

--- Comment #21 from Ryosuke Niwa <rniwa at webkit.org> ---
(In reply to Eric Liang from comment #20)
> Comment on attachment 360279 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=360279&action=review
> 
> >> LayoutTests/accessibility/press-not-work-for-disabled-menu-list.html:56
> >> +        }, 9);
> > 
> > 9 or 0?
> 
> The idea here is that because a successful AXPress waits on the UI process
> to display, it would wait for a short time to check the attribute. Although
> our expectations with disabled form controls don't need this wait, I still
> "pretend" that we need this wait because otherwise the check is meaningless.

We shouldn't be using a random timeout like this to wait for that. What exactly are you waiting for? There is a lot of milestones / events that we can wait for in UIScriptController.

> >> LayoutTests/accessibility/press-not-work-for-disabled-menu-list.html:71
> >> +        }, 10);
> > 
> > this needs to be 10?
> 
> This is an arbitrary wait time in which we assume a successful initiation of
> UI process needs. I don't really know how long I should set this number
> though.

Again, we shouldn't be doing that. The way to enforce UI process getting an IPC is to execute a script via UIScriptController

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190128/19a42f94/attachment.html>