[Webkit-unassigned] [Bug 193878] AX: VoiceOver allows to interact with a disabled <select> element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=193878

--- Comment #4 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 360261
  --> https://bugs.webkit.org/attachment.cgi?id=360261
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360261&action=review

> Source/WebCore/accessibility/AccessibilityMenuList.cpp:48
> +    Element* element = this->element();

auto element = this->element();
if (!element || element->isDsiabled())
   return false;

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3160
> +    // Used by DRT to find an accessible node by its element id.

comment is wrong

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3161
> +    if ([attributeName isEqualToString:@"AXDRTCollaspedAttribute"])

spelled wrong AXDRTCollaspedAttribute

> LayoutTests/accessibility/press-not-work-for-disabled-menu-list.html:9
> +  <select id="test1" disabled>

no indent on these controls

> LayoutTests/accessibility/press-not-work-for-disabled-menu-list.html:18
> +  <select id="test2" disabled aria-disabled="true">

can you add a test for disabled and aria-disabled='false"

> LayoutTests/accessibility/press-not-work-for-disabled-menu-list.html:34
> +    //Dont have tests for 'enabled' controls because when menu list opens a popup, it hangs on LayoutTests.

// We don't test for enabled controls because opening menu lists waits on the UI process to display the menu.

> LayoutTests/accessibility/press-not-work-for-disabled-menu-list.html:39
> +      jsTestIsAsync = true;

make sure indentation is 4 spaces every where

> LayoutTests/accessibility/press-not-work-for-disabled-menu-list.html:44
> +        pressNext();

can you verify that collapsed is false before you start

> LayoutTests/accessibility/press-not-work-for-disabled-menu-list.html:48
> +      }, 10);

do we need to wait 10 or can we just do it after 0

> LayoutTests/accessibility/press-not-work-for-disabled-menu-list.html:52
> +    {

make sure { on previous line

> LayoutTests/accessibility/press-not-work-for-disabled-menu-list.html:65
> +        }, 20);

do we need to wait 20?

> LayoutTests/accessibility/press-not-work-for-disabled-menu-list.html:81
> +        }, 20);

do we need to wait 20?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190127/59ca755f/attachment.html>