[Webkit-unassigned] [Bug 193806] [PlayStaton] Upstream playstation's remote inspector server

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=193806

--- Comment #3 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 360074
  --> https://bugs.webkit.org/attachment.cgi?id=360074
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360074&action=review

Fix WPE and let's run this by someone with more remote inspector experience. Overall looks good.

> Source/JavaScriptCore/SourcesGTK.txt:31
> -inspector/remote/glib/RemoteConnectionToTargetGlib.cpp
> +inspector/remote/generic/RemoteConnectionToTargetGeneric.cpp

You forgot to do this with WPE hence the build failure.

> Source/JavaScriptCore/inspector/remote/RemoteInspector.h:70
> +typedef RefPtr<TargetInfo> TargetListing;

Should prefer using.

> Source/JavaScriptCore/inspector/remote/generic/RemoteInspectorGeneric.cpp:40
> +ConnectionIdentifier RemoteInspector::connectionIdentifier = -1;

I saw -1 used in a few places. Probably want that to be a constant if you're using that.

> Source/JavaScriptCore/inspector/remote/generic/RemoteInspectorGeneric.cpp:132
> +    std::lock_guard<Lock> lock(m_mutex);

I'm not sure about these uses of std::lock_guard. It is used quite a bit in bmalloc but other than that its used sporadically.

> Source/JavaScriptCore/inspector/remote/generic/RemoteInspectorGeneric.cpp:240
> +    return;

Remove

> Source/JavaScriptCore/inspector/remote/generic/RemoteInspectorGeneric.cpp:245
> +    return;

Remove

> Source/JavaScriptCore/inspector/remote/playstation/RemoteInspectorSocket.h:40
> +#if OS(UNIX)
> +#include <poll.h>
> +#endif

Remove the #if we know its UNIX.

> Source/JavaScriptCore/inspector/remote/playstation/RemoteInspectorSocketPlayStation.cpp:40
> +#if OS(UNIX)
> +#include <arpa/inet.h>
> +#include <netinet/in.h>
> +#include <sys/socket.h>
> +#include <sys/un.h>
> +#include <unistd.h>
> +#endif

Remove the #if

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190125/4b289e73/attachment-0001.html>