[Webkit-unassigned] [Bug 193571] [GTK][WPE] Add API to add paths to sandbox

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=193571

--- Comment #34 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Patrick Griffis from comment #26)
> (In reply to Carlos Garcia Campos from comment #24)
> > Comment on attachment 359878 [details] 
> > > Source/WebKit/UIProcess/Launcher/ProcessLauncher.h:49
> > > +#if PLATFORM(GTK) || PLATFORM(WPE)
> > > +enum class SandboxPermission {
> > > +    ReadOnly,
> > > +    ReadWrite,
> > > +};
> > > +#endif
> > 
> > I think this belongs to WebProcessPool.h, where the api is defined.
> 
> I avoided this since it complicated header include order. I think its fine
> since ProcessLauncher is the end API imo.

It's ok if it simplifies things, I guess.

> > > Source/WebKit/UIProcess/glib/WebProcessProxyGLib.cpp:47
> > > +    launchOptions.extraSandboxPaths = m_processPool->sandboxPaths();
> > 
> > Could we make the Vector<CString> here instead of passing the map to the
> > launcher? That way we don't copy the map for sure.
> 
> Seems like a strange point to do it. The contents of the args are very
> backend specific (we do technically have two Flatpak and Bubblewrap).

Yes, you are right, what happens with these paths when flatpak launcher is used then?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190125/a875ece9/attachment.html>