[Webkit-unassigned] [Bug 193571] [GTK][WPE] Add API to add paths to sandbox

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 24 09:21:54 PST 2019


https://bugs.webkit.org/show_bug.cgi?id=193571

--- Comment #29 from Patrick Griffis <pgriffis at igalia.com> ---
(In reply to youenn fablet from comment #28)
> Comment on attachment 360011 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=360011&action=review
> 
> > Source/WebKit/ChangeLog:4
> > +        https://bugs.webkit.org/show_bug.cgi?id=193571
> 
> Can you describe the use cases for this API?
> Which folders are to be sandboxed?

This exposes a public api for users to add custom paths which could be anything.

> > Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp:763
> > +            sandboxArgs.appendVector(Vector<CString>({
> 
> Do you need "({" or just one of these.

Seems to require both.

> > Source/WebKit/UIProcess/glib/WebProcessProxyGLib.cpp:47
> > +    launchOptions.extraSandboxPaths = m_processPool->sandboxPaths();
> 
> The extra sandbox paths seem specific to web processes.
> Should the name be made explicit with that regards?

Sure what would be the convention for that?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190124/cdd04c14/attachment-0001.html>


More information about the webkit-unassigned mailing list