[Webkit-unassigned] [Bug 193750] New: check-webkit-style should warn when using soft-linking macros in a header

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=193750

            Bug ID: 193750
           Summary: check-webkit-style should warn when using soft-linking
                    macros in a header
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ddkilzer at webkit.org
                CC: lforschler at apple.com

check-webkit-style should warn when using soft-linking macros in a header.

Using the soft-linking macros in a header will lead to code being compiled in every translation unit (source file) that the header is included in, which is usually not what the author intends, and leads to duplicate code.

Example output on pre-existing files:

$ ./Tools/Scripts/check-webkit-style -f '-,+softlink/header' Source/WebCore/PAL
ERROR: Source/WebCore/PAL/pal/spi/ios/DataDetectorsUISPI.h:65:  Never soft-link frameworks in headers since this results in duplicate code in each source file where it is included.  [softlink/header] [5]
ERROR: Source/WebCore/PAL/pal/spi/mac/DataDetectorsSPI.h:109:  Never soft-link frameworks in headers since this results in duplicate code in each source file where it is included.  [softlink/header] [5]
ERROR: Source/WebCore/PAL/pal/spi/mac/DataDetectorsSPI.h:110:  Never soft-link frameworks in headers since this results in duplicate code in each source file where it is included.  [softlink/header] [5]
ERROR: Source/WebCore/PAL/pal/spi/mac/TUCallSPI.h:38:  Never soft-link frameworks in headers since this results in duplicate code in each source file where it is included.  [softlink/header] [5]
ERROR: Source/WebCore/PAL/pal/spi/mac/LookupSPI.h:33:  Never soft-link frameworks in headers since this results in duplicate code in each source file where it is included.  [softlink/header] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/NSAttributedStringSPI.h:34:  Never soft-link frameworks in headers since this results in duplicate code in each source file where it is included.  [softlink/header] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/RevealSPI.h:32:  Never soft-link frameworks in headers since this results in duplicate code in each source file where it is included.  [softlink/header] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/RevealSPI.h:33:  Never soft-link frameworks in headers since this results in duplicate code in each source file where it is included.  [softlink/header] [5]
Total errors found: 8 in 176 files

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190124/6cfde320/attachment.html>