[Webkit-unassigned] [Bug 193730] Web Inspector: CPU Usage Timeline

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=193730

--- Comment #8 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 359929
  --> https://bugs.webkit.org/attachment.cgi?id=359929
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=359929&action=review

> Source/WebInspectorUI/UserInterface/Views/CPUTimelineOverviewGraph.js:119
> +        let intervalWidth = (samplingRatePerSecond / secondsPerPixel);
> +        const minimumDisplayHeight = 2;
> +
> +        // Bars for each record.
> +        for (let record of visibleRecords) {
> +            let w = intervalWidth;
> +            let h = Math.max(minimumDisplayHeight, yScale(record.usage));
> +            let x = xScale(record.startTime - (samplingRatePerSecond / 2));
> +            let y = height - h;
> +            this._chart.addBar(x, y, w, h);
> +        }

Currently this sizes bars at 500ms wide, where the center of the bar is the time of the sample. Devin has pointed out that we may want the end of the bar to be the time of the sample, so that if developers select the range of the bar they will see all of the activity leading up to the sample and not some activity that may have happened after the sample. I think that is valid, but at the low sample rate, I'm not sure it matters as much. I think we will want to end up with finer grained categorization (something at a 1ms interval), and if we get in the detail view then the placement of the samples is not as important.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190123/b59a8c29/attachment.html>