[Webkit-unassigned] [Bug 193731] ASSERTION FAILED: m_connection in WebKit::ChildProcessProxy::connection()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 23 12:35:52 PST 2019


https://bugs.webkit.org/show_bug.cgi?id=193731

--- Comment #2 from Daniel Bates <dbates at webkit.org> ---
Maybe the backtrace says something about the WebPage not tearing down recognizer correctly on process termination? If so, then I can sort of see the value of <https://trac.webkit.org/browser/trunk/Source/WebKit/UIProcess/ChildProcessProxy.h?rev=240269#L57>. But it still feels weird to have an ASSERT(m_connection) in WebKit::ChildProcessProxy::connection() given that it returns a pointer AND the caller -[WKContentView(WKInteraction) ensurePositionInformationIsUpToDate:] hit this when trying to check if connection was null! So, the caller was aware of this possibility. Quick grep showed me that most callers also null check connection. So, again, what is the point of the ASSERT? To catch what I wrote in the first sentence?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190123/e6ce5bf2/attachment-0001.html>


More information about the webkit-unassigned mailing list