[Webkit-unassigned] [Bug 193571] [GTK][WPE] Add API to add paths to sandbox

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 22 14:08:07 PST 2019


--- Comment #18 from Patrick Griffis <pgriffis at igalia.com> ---
(In reply to Michael Catanzaro from comment #16)
> Comment on attachment 359754 [details] 
> > Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp:1189
> > +void webkit_web_context_add_path_to_sandbox(WebKitWebContext* context, const char* path, gboolean read_only)
> Please add an enum or the public API, too. WebKitSandboxPermission or
> something like that.

Feels very not GObjecty.

(In reply to Michael Catanzaro from comment #17)
> Also, since the application now gets to choose which paths get whitelisted,
> we should g_warning() if the path doesn't exist to let the application know
> about the bug. That can be done in the web process to avoid sync UI process
> API.

We don't actually know this since it failing or not happens in `bwrap`. We can check if it exists in the sandbox after everything launched but I dunno, feels like a lot of work for a warning.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190122/4f97aa96/attachment.html>

More information about the webkit-unassigned mailing list