[Webkit-unassigned] [Bug 193320] [GTK] Several resourceLoadStatistics tests are failing since r239816 "Create a WebResourceLoadStatisticsStore attached to the NetworkSession"

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 22 12:58:39 PST 2019


https://bugs.webkit.org/show_bug.cgi?id=193320

--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
(In reply to Brent Fulgham from comment #1)
> I was a little confused with this code on GTK/WPE, since the feature defines
> for non-Apple builds seems to have it off:
> 
> WebKitFeatures.cmake:   
> WEBKIT_OPTION_DEFINE(ENABLE_RESOURCE_LOAD_STATISTICS "Toggle resource load
> statistics support" PRIVATE OFF)

Yes, we're working on turning it on for WPE and GTK, but not there yet.

> So, I moved the websiteDataStore().resourceLoadStatistics() access inside a
> macro, since that stuff shouldn't exist if the build flag is turned off. GTK
> (and probably others) seem to be building a weird half on/half off version
> of the feature.

Well we build with it OFF, as you see. If the code doesn't respect the flag, I'd say that's a bug. Seems almost all the tests passed for a long time even though it's turned OFF, which is surprising.

> I think GTK either needs to turn the feature flag on, or disable the tests.
> 
> As a quick fix, you could just remove the "#if
> ENABLE(RESOURCE_LOAD_STATISTICS)" I added in WebPageProxy.cpp.

I think I'm just going to skip the tests.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190122/9bdf2af5/attachment.html>


More information about the webkit-unassigned mailing list