[Webkit-unassigned] [Bug 193571] [GTK][WPE] Add API to add paths to sandbox

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 22 12:19:28 PST 2019


--- Comment #16 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 359754
  --> https://bugs.webkit.org/attachment.cgi?id=359754

View in context: https://bugs.webkit.org/attachment.cgi?id=359754&action=review

> Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp:1182
> + * has been created otherwise it will be silently ignored. It is a fatal error to

created; otherwise,

> Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp:1189
> +void webkit_web_context_add_path_to_sandbox(WebKitWebContext* context, const char* path, gboolean read_only)

Please add an enum or the public API, too. WebKitSandboxPermission or something like that.

> Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp:763
> +            const CString& path = WebCore::FileSystem::fileSystemRepresentation(pathAndPermission.key);

It returns a copy, not a reference, so:

CString path = ...;

(Seeing the reference had me checking the function to figure out how it could possibly work safely.)

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190122/d4e85c32/attachment-0001.html>

More information about the webkit-unassigned mailing list