[Webkit-unassigned] [Bug 193571] [GTK][WPE] Add API to add paths to sandbox

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=193571

--- Comment #12 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 359484
  --> https://bugs.webkit.org/attachment.cgi?id=359484
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359484&action=review

>>> Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp:1182
>>> + * has been created otherwise it will be silently ignored. It is a fatal error to
>> 
>> Maybe we should attempt a g_mkdir_with_parents(), so we don't have to worry about this if the directory is writable? Bad idea?
>> 
>> We could add a flags parameter to control the behavior?
> 
> Well its blocking IO...

OK, no blocking I/O!

> Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp:763
> +        // Extra paths are stored as a single string and need to be manually split
> +        // They are in the format <path>:<rw|ro>\0  (see WebProcessProxyGLib.cpp)

Well here is how we'll make a final determination about sandbox paths. Paths can contain < and > and : and | and even embedded \0 characters. This is a good argument for adding an #ifdef in the LaunchOptions. Also, be sure to pass the path through WebCore::Filesystem::stringFromFilesystemRepresentation. Programming is hard; too many things you have to remember. :S

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190122/ac473ec4/attachment.html>