[Webkit-unassigned] [Bug 193585] Add API for setting MediaCacheDirectory in WK Context Config.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=193585

--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 359528
  --> https://bugs.webkit.org/attachment.cgi?id=359528
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359528&action=review

That's true, we don't want to add new C API unless it's needed by the test runner, because the C API is neither public nor stable. But this patch *does* use it in the test runner. So I actually think this patch is fine. It needs to be approved by an owner, though.

> Source/WebKit/ChangeLog:3
> +        Add API for setting MediaCacheDirectory in WK Context Config.

I would name this something like: "TestController should set media cache directory properly". Adding the new C API is uninteresting, because the C API is not public and applications cannot use it. It's just an implementation detail of WebKit. (I know Comcast has patched WebKit to expose the C API, but that's a bad idea.) But fixing the TestController to set the media cache directory is interesting.

> Source/WebKit/ChangeLog:10
> +
> +

Only one blank line here.

> Source/WebKit/UIProcess/API/C/WKContextConfigurationRef.cpp:131
> +
> +

Only one blank line here too.

> Tools/ChangeLog:10
> +
> +

Juts one blank line here too.

> Tools/WebKitTestRunner/TestController.cpp:462
> +        WKContextConfigurationSetMediaCacheDirectory(configuration.get(), toWK(temporaryFolder + separator + "MediaCache").get());

Where is MediaCache being saved currently?

Is this the only storage directory that TestController is missing here?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190121/8bddc00f/attachment.html>