[Webkit-unassigned] [Bug 193649] Move delegatesScrolling() tests to lower level conversion function in ScrollView

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 21 03:04:28 PST 2019


https://bugs.webkit.org/show_bug.cgi?id=193649

Frédéric Wang (:fredw) <fred.wang at free.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #359679|review?                     |review+
              Flags|                            |

--- Comment #3 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 359679
  --> https://bugs.webkit.org/attachment.cgi?id=359679
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359679&action=review

This LGTMs, thanks!

> Source/WebCore/platform/ScrollView.cpp:-864
> -    

This is reverting what was added in bug 186956. I guess your patch is the right way to fix it.

> Source/WebCore/platform/ScrollView.cpp:-877
> -

I'm curious if this will fix bug 184297 as the patch I uploaded there does similar thing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190121/56358d31/attachment.html>


More information about the webkit-unassigned mailing list