[Webkit-unassigned] [Bug 193630] REGRESSION(r240174): [GTK] Layout test fast/images/image-map-outline-in-positioned-container.html is failing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 20 15:39:43 PST 2019


--- Comment #2 from Daniel Bates <dbates at webkit.org> ---
(In reply to Michael Catanzaro from comment #0)
> Layout test fast/images/image-map-outline-in-positioned-container.html is
> failing for GTK since r240174 "CSS auto focus-ring outlines don't render on
> iOS". The autofocus is no longer rendered:
> https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/
> r240208%20(9437)/fast/images/image-map-outline-in-positioned-container-diffs.
> html
> I think the problem is in RenderImage::paintAreaElementFocusRing. 

Yes, there is a problem here. Oops! Shouldn't have tried to do two things at once: inverting the if-else and get this code working for PLATFORM(IOS_FAMILY) && ENABLE(FULL_KEYBOARD_ACCESS).

> Here some
> code that used to be cross-platform was changed to be Cocoa-specific by
> moving it inside the Cocoa-specific ENABLE(FULL_KEYBOARD_ACCESS) guard. I'm
> not sure what the right guard would be here, but perhaps

Yes, that would fix it! I am not near a computer with a checkout. If you can fix I would appreciate it.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190120/1cd099ae/attachment.html>

More information about the webkit-unassigned mailing list