[Webkit-unassigned] [Bug 193615] New: Web Inspector: Styles: refactor properties/allProperties/visibleProperties/allVisibleProperties
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jan 19 17:43:55 PST 2019
https://bugs.webkit.org/show_bug.cgi?id=193615
Bug ID: 193615
Summary: Web Inspector: Styles: refactor
properties/allProperties/visibleProperties/allVisibleP
roperties
Product: WebKit
Version: WebKit Nightly Build
Hardware: All
OS: All
Status: ASSIGNED
Severity: Normal
Priority: P2
Component: Web Inspector
Assignee: webkit-unassigned at lists.webkit.org
Reporter: nvasilyev at apple.com
CC: inspector-bugzilla-changes at group.apple.com
1. properties vs allProperties
`allProperties` is an array of both enabled and disabled properties.
`properties` is an array of only enabled properties:
this._properties = properties.filter((property) => property.enabled);
I find myself forgetting the difference between the two every 12 months. I suggest to rename:
properties -> enabledProperties
allProperties -> properties
2. visibleProperties vs allVisibleProperties
`visibleProperties` is unused and should be removed.
`allVisibleProperties` should be renamed to `visibleProperties`.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190120/57eff11f/attachment.html>
More information about the webkit-unassigned
mailing list