[Webkit-unassigned] [Bug 192980] [css-lists] Fix list marker issues related to line breaks and markers disappearance

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=192980

--- Comment #71 from cathiechen <cathiechen at igalia.com> ---
Comment on attachment 359016
  --> https://bugs.webkit.org/attachment.cgi?id=359016
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359016&action=review

Hi Simon,
Thanks for the review :)

>> Source/WebCore/ChangeLog:12
>> +        1. Create a zero-height anonymous parent for marker (to eleminate the
> 
> eleminate -> eliminate

Done

>> Source/WebCore/ChangeLog:14
>> +        2. Reposition the position of marker after all list item's children
> 
> "Reposition the position of marker after" -> "Reposition the marker to be after"

Done

>> Source/WebCore/rendering/updating/RenderTreeBuilderList.cpp:80
>> +static void forceLogicalHeight(RenderElement& element, Length&& height)
> 
> Don't call the argument 'element'. That makes it sound like an HTMLElement.

Done. Changed it to renderer.

>> Source/WebCore/rendering/updating/RenderTreeBuilderList.cpp:125
>> +    // Prepare for block direction align.
> 
> This comment doesn't add anything.

Done

>> Source/WebCore/rendering/updating/RenderTreeBuilderList.cpp:127
>> +        // Deal with the situation of render tree changed.
> 
> This comment doesn't add anything.

Done

>> Source/WebCore/rendering/updating/RenderTreeBuilderList.cpp:187
>> +                    m_builder.attach(listItemRenderer, WTFMove(newMarkerRenderer), beforeChild);
> 
> All these repeated "m_builder.attach(listItemRenderer, <something>, beforeChild);" makes me think this code could be refactored to be much cleaner. Generally, if you have code that has multiple calls to a function with different parameters, you should factor it to have a single call.
> 
> You could have a function or lambda that returns the appropriate marker (original or new), and just have one call to m_builder.attach().

Done. Thanks:)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190119/7abe6e62/attachment-0001.html>