[Webkit-unassigned] [Bug 192586] [WebAudio] Call AudioContext::uninitialize() immediately when the AudioContext is stopped

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 18 12:38:44 PST 2019


https://bugs.webkit.org/show_bug.cgi?id=192586

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com

--- Comment #11 from Darin Adler <darin at apple.com> ---
(In reply to Yacine Bandou from comment #0)
> This modification can now be reverted without regression in WebAudio tests.

I’m sorry; I don’t understand why this is the bar for knowing whether the code is needed. Do we have coverage for this teardown scenario in the WebAudio tests? The original patch when this change was made did not add any new tests.

It’s absolutely clear that we want to stop immediately.

What’s not so clear is if the problems with reentrancy and active DOM object teardown that originally motivated this change are covered with tests and have been solved. I am concerned about the test coverage.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190118/2b0b8c61/attachment-0001.html>


More information about the webkit-unassigned mailing list