[Webkit-unassigned] [Bug 193571] [GTK][WPE] Add API to add paths to sandbox

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=193571

Adrian Perez <aperez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aperez at igalia.com

--- Comment #4 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 359484
  --> https://bugs.webkit.org/attachment.cgi?id=359484
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359484&action=review

Informally reviewing... Patch overall looks good, there's only one change
I would request before landing it.

> Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp:1195
> +        g_error("Sandbox paths cannot be changed after subprocesses were spawned.");

If it is an error to add paths after a subprocess was spawned, I think we
want a an early “return” here to avoid calling “appendSandboxPaths()” below
to modify the list when there are already processes running -- otherwise the
processes spawned afterwards will have a different set of paths applied to
them.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190118/58bf7fd6/attachment.html>