[Webkit-unassigned] [Bug 193536] Base.xcconfig should be identical across all projects

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=193536

--- Comment #3 from Jer Noble <jer.noble at apple.com> ---
(In reply to mitz from comment #2)
> (In reply to Jer Noble from comment #0)
> > Created attachment 359381 [details]
> > Counts-of-statements-in-Base-xcconfig
> 
> Is 20 the highest possible score?

Yes, there are 20 Base.xcconfig files in the WebKit repo, 10 of which are in Source/.

> > Base.xcconfig should provide a "base" level of definitions for all projects,
> > with per-project definitions in ${ProjectName}.xcconfig.
> 
> Since some projects have a target whose name is the same as the project
> name, maybe literally Project.xcconfig, or ${ProjectName}Base.xcconfig would
> work better.

Sure, Project.xcconfig would be a good convention.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190117/5225f5bc/attachment.html>