[Webkit-unassigned] [Bug 192192] REGRESSION(r?): Web Inspector: Reloading no longer picks up changes in source files

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 15 14:39:08 PST 2019


https://bugs.webkit.org/show_bug.cgi?id=192192

Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joepeck at webkit.org

--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
The old reload would do:

    location.reload()

Which ultimately does a load ignoring the cache in WebCore:

    void FrameLoader::reload(OptionSet<ReloadOption> options)
    {
        ...
        ResourceRequest& request = loader->request();

        // FIXME: We don't have a mechanism to revalidate the main resource without reloading at the moment.
        request.setCachePolicy(ResourceRequestCachePolicy::ReloadIgnoringCacheData);
        ...
    }

The new reload of Web Inspector (for PSON) - InspectorFrontendHost.reopen, just closes and opens the Web Inspector. This does an initial WebPageProxy::loadRequest which doesn't ignore the cache.

    void WebInspectorProxy::openLocalInspectorFrontend(bool canAttach, bool underTest)
    {
        ...
        m_inspectorPage->loadRequest(URL(URL(), m_underTest ? WebInspectorProxy::inspectorTestPageURL() : WebInspectorProxy::inspectorPageURL()));
    }

If we wanted to get this working for inspector² we would need some way to open the inspector ignoring the cache.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190115/e0ad3d57/attachment.html>


More information about the webkit-unassigned mailing list