[Webkit-unassigned] [Bug 193380] New: [GTK] Build fails with OpenGL disabled due to missing PlatformWheelEvent::isEndOfNonMomentumScroll()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=193380

            Bug ID: 193380
           Summary: [GTK] Build fails with OpenGL disabled due to missing
                    PlatformWheelEvent::isEndOfNonMomentumScroll()
           Product: WebKit
           Version: Other
          Hardware: Unspecified
                OS: Linux
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: aperez at igalia.com
                CC: lforschler at apple.com

This issue has been found by the Buildroot autobuild infrastructure,
the relevant part of the build log is copied below; the complete build
configuration can be found at:

  http://autobuild.buildroot.net/results/dd89d219efb711ecaa71a268bd6b36b06b035c80

The issue here is that OpenGL support is disabled at build time (not how
the config file has both BR2_PACKAGE_LIBGTK3_X11 and BR2_PACKAGE_HAS_LIBGLES
disabled, which results in -DENABLE_OPENGL=OFF and -DENABLE_GLES2=OFF being
passed to CMake.

This results in ENABLE_ASYNC_SCROLLING being disabled, due to this bit in
Source/cmake/OptionsGTK.cmake:

   WEBKIT_OPTION_DEPEND(ENABLE_ASYNC_SCROLLING ENABLE_OPENGL)

Then, in Source/WebCore/platform/PlatformWheelEvent.h the declaration for
the isEndOfNonMomentumScroll() method is guarded with ENABLE(ASYNC_SCROLLING)
but the actual implementation is guarded with PLATFORM(GTK) — resulting in
the error below due to the missing declaration.

WebKitGTK+ version 2.22.5 is affected, but the issue seems to be solved
in trunk.

----

In file included from /home/buildroot/autobuild/run/instance-2/output/build/webkitgtk-2.22.5/Source/WebCore/dom/WheelEvent.h:28:0,
                 from /home/buildroot/autobuild/run/instance-2/output/build/webkitgtk-2.22.5/DerivedSources/WebCore/EventHeaders.h:227,
                 from /home/buildroot/autobuild/run/instance-2/output/build/webkitgtk-2.22.5/DerivedSources/WebCore/EventFactory.cpp:29,
                 from /home/buildroot/autobuild/run/instance-2/output/build/webkitgtk-2.22.5/DerivedSources/WebCore/unified-sources/UnifiedSource1.cpp:3:
/home/buildroot/autobuild/run/instance-2/output/build/webkitgtk-2.22.5/Source/WebCore/platform/PlatformWheelEvent.h:216:60: error: no 'bool WebCore::PlatformWheelEvent::isEndOfNonMomentumScroll() const' member function declared in class 'WebCore::PlatformWheelEvent'
 inline bool PlatformWheelEvent::isEndOfNonMomentumScroll() const
                                                            ^~~~~
/home/buildroot/autobuild/run/instance-2/output/build/webkitgtk-2.22.5/Source/WebCore/platform/PlatformWheelEvent.h:221:67: error: no 'bool WebCore::PlatformWheelEvent::isTransitioningToMomentumScroll() const' member function declared in class 'WebCore::PlatformWheelEvent'
 inline bool PlatformWheelEvent::isTransitioningToMomentumScroll() const
                                                                   ^~~~~

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190112/e9165c5b/attachment.html>