[Webkit-unassigned] [Bug 193273] Import css-lists testcases from web platform tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=193273

cathiechen <cathiechen at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #358775|1                           |0
        is obsolete|                            |

--- Comment #24 from cathiechen <cathiechen at igalia.com> ---
Comment on attachment 358775
  --> https://bugs.webkit.org/attachment.cgi?id=358775
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358775&action=review

Hi Fred,

Thanks for the review! :)

>> LayoutTests/ChangeLog:6
>> +        Reviewed by  Daniel Bates.
> 
> nit: there should be only one space between "by" and "Daniel"

Done

>> LayoutTests/ChangeLog:10
>> +        * platform/ios-simulator-wk2/TestExpectations:
> 
> I wonder if we actually want ios-simulator-wk2 rather than ios-simulator but I guess that's ok for now ; someone will rebaseline the tests if necessary.

Done. Moved it to ios-simulator/TestExpectations.

>> LayoutTests/platform/gtk/TestExpectations:3660
>> +# css-lists reftests that are failing
> 
> thinking again, maybe you can just remove this comment as it does not bring anything new (sorry for my previous suggestion)

Done

>> LayoutTests/platform/ios-simulator-wk2/TestExpectations:48
>> +# css-lists reftests that are failing
> 
> lower-greek passes so I guess you can just remove this comment.

Done

>> LayoutTests/platform/ios-simulator-wk2/TestExpectations:52
>> +imported/w3c/web-platform-tests/css/css-lists/list-and-writing-mode-001.html [ Failure ]
> 
> The diff we get from comment 20 is just
> 
> -FAIL list and writing-mode assert_equals: the height of li should be 45px, and no extra line generated expected 45 but got 63
> +FAIL list and writing-mode assert_equals: the height of li should be 45px, and no extra line generated expected 45 but got 65
> 
> so I would just add a specific list-and-writing-mode-001-expected.txt file for this platform.

Done

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190110/ceb67a7f/attachment.html>