[Webkit-unassigned] [Bug 193273] Import css-lists testcases from web platform tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 9 05:43:04 PST 2019


https://bugs.webkit.org/show_bug.cgi?id=193273

--- Comment #16 from cathiechen <cathiechen at igalia.com> ---
Comment on attachment 358694
  --> https://bugs.webkit.org/attachment.cgi?id=358694
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358694&action=review

>> LayoutTests/TestExpectations:2924
>> +# Import css-lists testcases
> 
> I would say
> # css-lists reftests that are failing

Done

>> LayoutTests/TestExpectations:2934
>> +imported/w3c/web-platform-tests/css/css-lists/list-and-writing-mode-001.html [ Pass Failure ]
> 
> I don't think you need this one if you have list-and-writing-mode-001-expected. "Pass Failure" is for flaky tests.

Done! Thanks!

>> LayoutTests/platform/ios-simulator-wk2/TestExpectations:48
>> +# Import css-lists testcases.
> 
> Same here. And I would explain why these tests have different behavior on iOS, if possible.

Done with comment.
These cases aren't related to zero-height. I couldn't give the precise explanation, so I'd better leave them.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190109/72481521/attachment.html>


More information about the webkit-unassigned mailing list