[Webkit-unassigned] [Bug 192496] Enable DFG on ARM/Linux again

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=192496

Yusuke Suzuki <yusukesuzuki at slowstart.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #358603|review?                     |review+
              Flags|                            |

--- Comment #12 from Yusuke Suzuki <yusukesuzuki at slowstart.org> ---
Comment on attachment 358603
  --> https://bugs.webkit.org/attachment.cgi?id=358603
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358603&action=review

r=me with nits.

> Source/JavaScriptCore/dfg/DFGOSRExit.cpp:142
> +            // FIXME: support callee-saved floating point registers on 32-bit architectures

Please file a bug with FIXME and add a url here.

> Source/JavaScriptCore/dfg/DFGOSRExit.cpp:172
> +            // FIXME: support callee-saved floating point registers on 32-bit architectures

Ditto.

> Source/JavaScriptCore/jit/GPRInfo.h:529
>  #if CPU(ARM)

I think we should use #if CPU(ARM_THUMB2) here since the following information is not correct for CPU(ARM) from now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190108/f210ccb7/attachment.html>