[Webkit-unassigned] [Bug 193204] Web Inspector: Remote inspector can crash if attempting to navigate inspector page

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=193204

--- Comment #4 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 358512
  --> https://bugs.webkit.org/attachment.cgi?id=358512
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=358512&action=review

>> Source/WebKit/UIProcess/mac/RemoteWebInspectorProxyMac.mm:88
>> +    m_inspectorView = adoptNS([[WKInspectorViewController alloc] initWithInspectedPage:nullptr]);
> 
> Just for my knowledge, is it preferred to use `nil` or `nullptr` in ObjC code?
> Is `nullptr` preferred here because the value expected by `initWithInspectedPage` is a `WebPageProxy`, which is a C++ object, or am I just overthinking things?

Using nil/nullptr and friends just like where to place the "*", the type is what matters:

    0 - never
    NULL - C type
    nullptr - C++ type
    nil - ObjC type
    Nil - ObjC Class type

I think that covers all the various cases.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190107/2d1d14a3/attachment-0001.html>