[Webkit-unassigned] [Bug 193204] Web Inspector: Remote inspector can crash if attempting to navigate inspector page

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=193204

Devin Rousso <drousso at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |drousso at apple.com
 Attachment #358512|review?                     |review+
              Flags|                            |

--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 358512
  --> https://bugs.webkit.org/attachment.cgi?id=358512
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=358512&action=review

rs=me, never a bad idea to add a nullptr check 😁

> Source/WebKit/UIProcess/mac/RemoteWebInspectorProxyMac.mm:88
> +    m_inspectorView = adoptNS([[WKInspectorViewController alloc] initWithInspectedPage:nullptr]);

Just for my knowledge, is it preferred to use `nil` or `nullptr` in ObjC code?
Is `nullptr` preferred here because the value expected by `initWithInspectedPage` is a `WebPageProxy`, which is a C++ object, or am I just overthinking things?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190107/068c3a98/attachment.html>