[Webkit-unassigned] [Bug 192030] Layout test should generate performance metrics

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=192030

--- Comment #21 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 356513
  --> https://bugs.webkit.org/attachment.cgi?id=356513
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356513&action=review

> Tools/ChangeLog:8
> +

Can you add a high-level comment about what's being done here? As a side note, add_test_perf_metric and test_perf_metrics probably deserve some commend as well.

> Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:122
> +def add_test_perf_metric(path, time, tests, depth, target_depth):

Can we append this function with an underscore since it's defiantly a private function?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190107/47883b02/attachment.html>