[Webkit-unassigned] [Bug 191303] DumpRenderTree should report unknown options

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191303

Frédéric Wang (:fredw) <fred.wang at free.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #358456|review?                     |review-
              Flags|                            |

--- Comment #7 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 358456
  --> https://bugs.webkit.org/attachment.cgi?id=358456
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358456&action=review

> Following are the options which are not handled in TestOptions.cpp

Can you please give details about:
(1) How did you get that list? And what are the associated tests (or the amount of such tests)
(2) The changes you experimented in TestOptions.cpp and how they affect the webkit-test-runner results for the tests in (1). None of the patches you uploaded seem to have any effect on the EWS bots.

> Tools/ChangeLog:10
> +

ChangeLog still does not contain any useful information.

> Tools/DumpRenderTree/TestOptions.cpp:111
> +            fprintf(stderr, "Unknown option %s\n", key.c_str());

I think ideally we should re-use some logging feature provided in WTF. This does not seem better than LOG_ERROR (which e.g. provides file and line number).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190107/b467817e/attachment.html>